feat(neptune): add new fixer neptune_cluster_public_snapshot_fixer
#5749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
provider/aws
danibarranqueroo
changed the title
neptune_cluster_public_snapshot_fixer
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5749 +/- ##
========================================
Coverage 89.89% 89.89%
========================================
Files 1128 1133 +5
Lines 35182 35285 +103
========================================
+ Hits 31628 31721 +93
- Misses 3554 3564 +10 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
MrCloudSec
approved these changes
Nov 22, 2024
MrCloudSec
deleted the
PRWLR-5328-set-neptune-db-manual-cluster-snapshot-as-not-public
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Developed a new fixer that modifies the snapshot settings of Neptune clusters to ensure they are private and not publicly accessible. This will help prevent unauthorized access to database snapshots, enhancing the security of stored data and reducing the risk of data leaks.
For the unit tests, moto does not work well with Neptune so I had to use Botocore.
Description
Added new fixer
neptune_cluster_public_snapshot_fixerwith its unit tests.Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.